Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add dictionary entries to set custom savefields #5502

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvela018
Copy link
Contributor

Description

Added entries in the transient dictionary for maxwell under setup_templates.py, to account for custom field saves of different types. This should be seen as a temporary solution. Perhaps this will be worked out as part of PR #5496

image

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@jvela018 jvela018 requested a review from gmalinve November 29, 2024 11:43
@jvela018 jvela018 changed the title [setup_templates.py][maxwell-transient] Add dictionary entries to set custom savefields FEAT: Add dictionary entries to set custom savefields Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (1e04243) to head (b41e0aa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5502      +/-   ##
==========================================
+ Coverage   80.76%   84.69%   +3.92%     
==========================================
  Files         143      143              
  Lines       60118    60120       +2     
==========================================
+ Hits        48557    50917    +2360     
+ Misses      11561     9203    -2358     

@gmalinve gmalinve marked this pull request as draft December 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant